Can any one help me do the code review for PR :https://issues.apache.org/jira/browse/IGNITE-8956

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Can any one help me do the code review for PR :https://issues.apache.org/jira/browse/IGNITE-8956

kcheng.mvp
This post was updated on .
Hi Dmitriy Govorukhin,

I have fixed the javadoc error, can you please review the PR?



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

kcheng.mvp
Dear igniters,

does anyone can help do the code review?

As this ticket is created by myself, I need someone else to help me do the
code review.


Thanks,
kcmvp



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

daradurvs
Hi,

I've commented your PR on the GitHub.


On Mon, Jul 9, 2018 at 5:21 AM kcheng.mvp <[hidden email]> wrote:

>
> Dear igniters,
>
> does anyone can help do the code review?
>
> As this ticket is created by myself, I need someone else to help me do the
> code review.
>
>
> Thanks,
> kcmvp
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/



--
Best Regards, Vyacheslav D.
Reply | Threaded
Open this post in threaded view
|

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

daradurvs
Now changes look good to me.

Dmitry, could you help with a final review and merge, please?
On Mon, Jul 9, 2018 at 9:30 AM Vyacheslav Daradur <[hidden email]> wrote:

>
> Hi,
>
> I've commented your PR on the GitHub.
>
>
> On Mon, Jul 9, 2018 at 5:21 AM kcheng.mvp <[hidden email]> wrote:
> >
> > Dear igniters,
> >
> > does anyone can help do the code review?
> >
> > As this ticket is created by myself, I need someone else to help me do the
> > code review.
> >
> >
> > Thanks,
> > kcmvp
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
>
>
> --
> Best Regards, Vyacheslav D.



--
Best Regards, Vyacheslav D.
Reply | Threaded
Open this post in threaded view
|

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

Dmitriy Pavlov
Done. Thank you for contribution and for review.

пн, 9 июл. 2018 г. в 12:37, Vyacheslav Daradur <[hidden email]>:

> Now changes look good to me.
>
> Dmitry, could you help with a final review and merge, please?
> On Mon, Jul 9, 2018 at 9:30 AM Vyacheslav Daradur <[hidden email]>
> wrote:
> >
> > Hi,
> >
> > I've commented your PR on the GitHub.
> >
> >
> > On Mon, Jul 9, 2018 at 5:21 AM kcheng.mvp <[hidden email]> wrote:
> > >
> > > Dear igniters,
> > >
> > > does anyone can help do the code review?
> > >
> > > As this ticket is created by myself, I need someone else to help me do
> the
> > > code review.
> > >
> > >
> > > Thanks,
> > > kcmvp
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
>
>
>
> --
> Best Regards, Vyacheslav D.
>