CacheJdbcPojoStoreFactory usability

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

CacheJdbcPojoStoreFactory usability

Valentin Kulichenko
Igniters,

I'm looking at CacheJdbcPojoStoreFactory and have a couple of questions:

   - We have a dataSource property there, but it's transient, so it's
   always null on remote nodes. I understand that data source should not be
   serialized. But why do we have it in the factory then?
   - We allow to set JdbcDialect, but it's not Serializable as well (why,
   BTW?). Moreover, there is a test that checks that we can't use H2Dialect in
   this factory. I'm confused, really :)

I also don't like that app context is not transient. I'm almost sure there
are scenarios when it's injected on remote node and then serialized.

Can anyone comment?

-Val
Reply | Threaded
Open this post in threaded view
|

Re: CacheJdbcPojoStoreFactory usability

yzhdanov
I agree on all points (can you please create a ticket and put this to it):

1. sppContext should be transient
2. dataSrc is in the factory so user can fully configure it.
3. really strange thing with h2 dialect. can you make it serializable?

Thanks!

--Yakov

2015-08-15 3:40 GMT+03:00 Valentin Kulichenko <[hidden email]
>:

> Igniters,
>
> I'm looking at CacheJdbcPojoStoreFactory and have a couple of questions:
>
>    - We have a dataSource property there, but it's transient, so it's
>    always null on remote nodes. I understand that data source should not be
>    serialized. But why do we have it in the factory then?
>    - We allow to set JdbcDialect, but it's not Serializable as well (why,
>    BTW?). Moreover, there is a test that checks that we can't use
> H2Dialect in
>    this factory. I'm confused, really :)
>
> I also don't like that app context is not transient. I'm almost sure there
> are scenarios when it's injected on remote node and then serialized.
>
> Can anyone comment?
>
> -Val
>
Reply | Threaded
Open this post in threaded view
|

Re: CacheJdbcPojoStoreFactory usability

Valentin Kulichenko
Ticket for described issues:
https://issues.apache.org/jira/browse/IGNITE-1262

-Val

On Mon, Aug 17, 2015 at 5:33 AM, Yakov Zhdanov <[hidden email]> wrote:

> I agree on all points (can you please create a ticket and put this to it):
>
> 1. sppContext should be transient
> 2. dataSrc is in the factory so user can fully configure it.
> 3. really strange thing with h2 dialect. can you make it serializable?
>
> Thanks!
>
> --Yakov
>
> 2015-08-15 3:40 GMT+03:00 Valentin Kulichenko <
> [hidden email]
> >:
>
> > Igniters,
> >
> > I'm looking at CacheJdbcPojoStoreFactory and have a couple of questions:
> >
> >    - We have a dataSource property there, but it's transient, so it's
> >    always null on remote nodes. I understand that data source should not
> be
> >    serialized. But why do we have it in the factory then?
> >    - We allow to set JdbcDialect, but it's not Serializable as well (why,
> >    BTW?). Moreover, there is a test that checks that we can't use
> > H2Dialect in
> >    this factory. I'm confused, really :)
> >
> > I also don't like that app context is not transient. I'm almost sure
> there
> > are scenarios when it's injected on remote node and then serialized.
> >
> > Can anyone comment?
> >
> > -Val
> >
>