Breaking change to spatial indexes to migrate to latest H2 version

[Vladimir Ozerov]

Igniters,

New H2 version 1.4.197 [1] was released recently. It contain a lot of
changes (>1000 commits) and some of them are very useful for us. Of most
importance is IN clause optimization which is currently one of our SQL pain
points.

Unfortunately, new version use updated dependency for spatial indexes.
Earlier it was "org.vividsolutions", now it is "org.locationtech". This is
the same product, only package name was changed.

It means that if we upgrade to newer H2 version all our users of spatial
indexes feature will have compilation and/or linkage errors. This is a
breaking change.

I propose to implement it still in AI 2.7. We still depend on H2 heavily
and cannot stop updates.

Any objections?

Vladimir.

[1] https://github.com/h2database/h2database/releases/tag/version-1.4.197
[2] https://issues.apache.org/jira/browse/IGNITE-4150

[dmagda]

Vladimir,

Do agree with you to switch to the new version within 2.7 time frame.

Could you please elaborate on this optimization

>
> Of most
> importance is IN clause optimization which is currently one of our SQL pain
> points.


Should I assume that now H2 considered indexes used within the IN clause?
It would be a huge optimization.

--
Denis


On Wed, Jun 6, 2018 at 12:54 AM, Vladimir Ozerov <[hidden email]>
wrote:

> Igniters,
>
> New H2 version 1.4.197 [1] was released recently. It contain a lot of
> changes (>1000 commits) and some of them are very useful for us. Of most
> importance is IN clause optimization which is currently one of our SQL pain
> points.
>
> Unfortunately, new version use updated dependency for spatial indexes.
> Earlier it was "org.vividsolutions", now it is "org.locationtech". This is
> the same product, only package name was changed.
>
> It means that if we upgrade to newer H2 version all our users of spatial
> indexes feature will have compilation and/or linkage errors. This is a
> breaking change.
>
> I propose to implement it still in AI 2.7. We still depend on H2 heavily
> and cannot stop updates.
>
> Any objections?
>
> Vladimir.
>
> [1] https://github.com/h2database/h2database/releases/tag/version-1.4.197
> [2] https://issues.apache.org/jira/browse/IGNITE-4150
>

[dsetrakyan]

Vladimir,

Can you please explain how our users will be affected? What does it mean to
use "spatial" indexes in Ignite?

D.

On Wed, Jun 6, 2018 at 12:54 AM, Vladimir Ozerov <[hidden email]>
wrote:

> Igniters,
>
> New H2 version 1.4.197 [1] was released recently. It contain a lot of
> changes (>1000 commits) and some of them are very useful for us. Of most
> importance is IN clause optimization which is currently one of our SQL pain
> points.
>
> Unfortunately, new version use updated dependency for spatial indexes.
> Earlier it was "org.vividsolutions", now it is "org.locationtech". This is
> the same product, only package name was changed.
>
> It means that if we upgrade to newer H2 version all our users of spatial
> indexes feature will have compilation and/or linkage errors. This is a
> breaking change.
>
> I propose to implement it still in AI 2.7. We still depend on H2 heavily
> and cannot stop updates.
>
> Any objections?
>
> Vladimir.
>
> [1] https://github.com/h2database/h2database/releases/tag/version-1.4.197
> [2] https://issues.apache.org/jira/browse/IGNITE-4150
>

[Vladimir Ozerov]

Dmitriy,

Spatial indexes is one of our features, packed as separate optional module
[1]. With proposed changes users of this feature will not be able to
migrate to 2.7 until they rewrite and recompile their code, because both
compile-time and run-time compatibility will be broken. Required changes to
the code are minimal - just change package names.

If there are no concerns, I will merge it to master branch in the nearest
time.

[1] https://apacheignite-sql.readme.io/docs/geospatial-support

On Thu, Jun 7, 2018 at 4:00 AM Dmitriy Setrakyan <[hidden email]>
wrote:

> Vladimir,
>
> Can you please explain how our users will be affected? What does it mean to
> use "spatial" indexes in Ignite?
>
> D.
>
> On Wed, Jun 6, 2018 at 12:54 AM, Vladimir Ozerov <[hidden email]>
> wrote:
>
> > Igniters,
> >
> > New H2 version 1.4.197 [1] was released recently. It contain a lot of
> > changes (>1000 commits) and some of them are very useful for us. Of most
> > importance is IN clause optimization which is currently one of our SQL
> pain
> > points.
> >
> > Unfortunately, new version use updated dependency for spatial indexes.
> > Earlier it was "org.vividsolutions", now it is "org.locationtech". This
> is
> > the same product, only package name was changed.
> >
> > It means that if we upgrade to newer H2 version all our users of spatial
> > indexes feature will have compilation and/or linkage errors. This is a
> > breaking change.
> >
> > I propose to implement it still in AI 2.7. We still depend on H2 heavily
> > and cannot stop updates.
> >
> > Any objections?
> >
> > Vladimir.
> >
> > [1]
> https://github.com/h2database/h2database/releases/tag/version-1.4.197
> > [2] https://issues.apache.org/jira/browse/IGNITE-4150
> >
>

[Sergey Kozlov]

Vladimir

The spatial module is not delivering in AI binaries (and does not provided
in AI maven repo). This the impact will be less than if it happended for
other modules.



On Tue, Aug 14, 2018 at 10:46 AM, Vladimir Ozerov <[hidden email]>
wrote:

> Dmitriy,
>
> Spatial indexes is one of our features, packed as separate optional module
> [1]. With proposed changes users of this feature will not be able to
> migrate to 2.7 until they rewrite and recompile their code, because both
> compile-time and run-time compatibility will be broken. Required changes to
> the code are minimal - just change package names.
>
> If there are no concerns, I will merge it to master branch in the nearest
> time.
>
> [1] https://apacheignite-sql.readme.io/docs/geospatial-support
>
> On Thu, Jun 7, 2018 at 4:00 AM Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > Vladimir,
> >
> > Can you please explain how our users will be affected? What does it mean
> to
> > use "spatial" indexes in Ignite?
> >
> > D.
> >
> > On Wed, Jun 6, 2018 at 12:54 AM, Vladimir Ozerov <[hidden email]>
> > wrote:
> >
> > > Igniters,
> > >
> > > New H2 version 1.4.197 [1] was released recently. It contain a lot of
> > > changes (>1000 commits) and some of them are very useful for us. Of
> most
> > > importance is IN clause optimization which is currently one of our SQL
> > pain
> > > points.
> > >
> > > Unfortunately, new version use updated dependency for spatial indexes.
> > > Earlier it was "org.vividsolutions", now it is "org.locationtech". This
> > is
> > > the same product, only package name was changed.
> > >
> > > It means that if we upgrade to newer H2 version all our users of
> spatial
> > > indexes feature will have compilation and/or linkage errors. This is a
> > > breaking change.
> > >
> > > I propose to implement it still in AI 2.7. We still depend on H2
> heavily
> > > and cannot stop updates.
> > >
> > > Any objections?
> > >
> > > Vladimir.
> > >
> > > [1]
> > https://github.com/h2database/h2database/releases/tag/version-1.4.197
> > > [2] https://issues.apache.org/jira/browse/IGNITE-4150
> > >
> >
>

--
Sergey Kozlov
GridGain Systems
www.gridgain.com

[dsetrakyan]

I tend to agree with Vladimir and Sergey. I would upgrade to the new H2
version and document this incompatibility with spatial indexes.

D.


On Tue, Aug 14, 2018 at 3:11 AM, Sergey Kozlov <[hidden email]> wrote:

> Vladimir
>
> The spatial module is not delivering in AI binaries (and does not provided
> in AI maven repo). This the impact will be less than if it happended for
> other modules.
>
>
>
> On Tue, Aug 14, 2018 at 10:46 AM, Vladimir Ozerov <[hidden email]>
> wrote:
>
> > Dmitriy,
> >
> > Spatial indexes is one of our features, packed as separate optional
> module
> > [1]. With proposed changes users of this feature will not be able to
> > migrate to 2.7 until they rewrite and recompile their code, because both
> > compile-time and run-time compatibility will be broken. Required changes
> to
> > the code are minimal - just change package names.
> >
> > If there are no concerns, I will merge it to master branch in the nearest
> > time.
> >
> > [1] https://apacheignite-sql.readme.io/docs/geospatial-support
> >
> > On Thu, Jun 7, 2018 at 4:00 AM Dmitriy Setrakyan <[hidden email]>
> > wrote:
> >
> > > Vladimir,
> > >
> > > Can you please explain how our users will be affected? What does it
> mean
> > to
> > > use "spatial" indexes in Ignite?
> > >
> > > D.
> > >
> > > On Wed, Jun 6, 2018 at 12:54 AM, Vladimir Ozerov <[hidden email]
> >
> > > wrote:
> > >
> > > > Igniters,
> > > >
> > > > New H2 version 1.4.197 [1] was released recently. It contain a lot of
> > > > changes (>1000 commits) and some of them are very useful for us. Of
> > most
> > > > importance is IN clause optimization which is currently one of our
> SQL
> > > pain
> > > > points.
> > > >
> > > > Unfortunately, new version use updated dependency for spatial
> indexes.
> > > > Earlier it was "org.vividsolutions", now it is "org.locationtech".
> This
> > > is
> > > > the same product, only package name was changed.
> > > >
> > > > It means that if we upgrade to newer H2 version all our users of
> > spatial
> > > > indexes feature will have compilation and/or linkage errors. This is
> a
> > > > breaking change.
> > > >
> > > > I propose to implement it still in AI 2.7. We still depend on H2
> > heavily
> > > > and cannot stop updates.
> > > >
> > > > Any objections?
> > > >
> > > > Vladimir.
> > > >
> > > > [1]
> > > https://github.com/h2database/h2database/releases/tag/version-1.4.197
> > > > [2] https://issues.apache.org/jira/browse/IGNITE-4150
> > > >
> > >
> >
>
>
>
> --
> Sergey Kozlov
> GridGain Systems
> www.gridgain.com
>