Allow arrays in node attributes for thin clients

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Allow arrays in node attributes for thin clients

Alex Kozhenkov
Hi guys!

We have a restriction to filter array values from node attributes if it is
not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).

It will be useful to allow arrays for any attribute with suffix ".features"
for external modules. Otherwise, these attributes are not allowed from
GridClient.

What do you think about allowing it?
Reply | Threaded
Open this post in threaded view
|

Re: Allow arrays in node attributes for thin clients

Pavel Tupitsyn
I think we agreed to make thin client attributes String-only [1]
However, this does not seem to be the case right now.

Anyway, I'd like to avoid complicating the protocol even further with magic
suffixes.
Can we simply use a String instead of an array?

[1]
http://apache-ignite-developers.2346864.n4.nabble.com/Add-user-attributes-to-thin-clients-td45273.html

On Tue, Mar 2, 2021 at 4:04 PM Alex Kozhenkov <[hidden email]> wrote:

> Hi guys!
>
> We have a restriction to filter array values from node attributes if it is
> not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).
>
> It will be useful to allow arrays for any attribute with suffix ".features"
> for external modules. Otherwise, these attributes are not allowed from
> GridClient.
>
> What do you think about allowing it?
>
Reply | Threaded
Open this post in threaded view
|

Re: Allow arrays in node attributes for thin clients

Alex Kozhenkov
OK, I got it.
Yes, we can use String instead.

вт, 2 мар. 2021 г. в 18:27, Pavel Tupitsyn <[hidden email]>:

> I think we agreed to make thin client attributes String-only [1]
> However, this does not seem to be the case right now.
>
> Anyway, I'd like to avoid complicating the protocol even further with magic
> suffixes.
> Can we simply use a String instead of an array?
>
> [1]
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Add-user-attributes-to-thin-clients-td45273.html
>
> On Tue, Mar 2, 2021 at 4:04 PM Alex Kozhenkov <[hidden email]> wrote:
>
> > Hi guys!
> >
> > We have a restriction to filter array values from node attributes if it
> is
> > not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).
> >
> > It will be useful to allow arrays for any attribute with suffix
> ".features"
> > for external modules. Otherwise, these attributes are not allowed from
> > GridClient.
> >
> > What do you think about allowing it?
> >
>