Adding ML to Ignite, IGNITE-4572

[Yuriy Babak]

Denis,

Yes, this module already in apache master branch.

Also I created ticket for module renaming, so we could discuss this renaming in IGNITE-5000

[oignatenko]

Denis, I prepared preliminary draft doc for readme.io, it reflects proposed rename. You can find it attached to JIRA IGNITE-4964

With regards to merge, per my reading of recent mail from Yury it is done except for module rename which is on its way to master now.

regards, Oleg

Denis Magda-2 wrote

Oleg, Nikita, Yuri,

Frankly, I don’t like how the module is named presently which is 'ignite-math’.

I propose to rename it to ‘ignite-ml’. Presently, it holds a small fraction of all ML functionality we might have in the future and this is why, thinking of future, it will be a right decision to name it accordingly.

Any concerns?

BTW, have the module been fully merged? I want to try to build it and check the examples.

—
Denis

> On Apr 14, 2017, at 7:05 AM, oignatenko <[hidden email]> wrote:
>
> Thank you Denis, that sounds like a good plan. I am working on it now. I
> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it when
> I have concrete details to share.
>
> Side note my build check completed successfully, although it took quite a
> bit of time: I cleaned my local maven repo to make sure that things really
> work from the clean state.
>
>
>
> --
> View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html
> Sent from the Apache Ignite Developers mailing list archive at Nabble.com.

[Denis Magda]

Thanks Oleg, I’ll review the doc a bit later.

Yuri, I’ve reopened IGNITE-5000. Please consider my latest notes and prepare one more pull-request:
https://issues.apache.org/jira/browse/IGNITE-5000 <https://issues.apache.org/jira/browse/IGNITE-5000>

—
Denis

> On Apr 17, 2017, at 8:48 AM, oignatenko <[hidden email]> wrote:
>
> Denis, I prepared preliminary draft doc for readme.io <http://readme.io/>, it reflects proposed
> rename. You can find it attached to JIRA IGNITE-4964
>
> With regards to merge, per my reading of recent mail from Yury it is done
> except for module rename which is on its way to master now.
>
> regards, Oleg
>
>
> Denis Magda-2 wrote
>> Oleg, Nikita, Yuri,
>>
>> Frankly, I don’t like how the module is named presently which is
>> 'ignite-math’.
>>
>> I propose to rename it to ‘ignite-ml’. Presently, it holds a small
>> fraction of all ML functionality we might have in the future and this is
>> why, thinking of future, it will be a right decision to name it
>> accordingly.
>>
>> Any concerns?
>>
>> BTW, have the module been fully merged? I want to try to build it and
>> check the examples.
>>
>> —
>> Denis
>>
>>> On Apr 14, 2017, at 7:05 AM, oignatenko &lt;
>
>> oignatenko@
>
>> &gt; wrote:
>>>
>>> Thank you Denis, that sounds like a good plan. I am working on it now. I
>>> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it
>>> when
>>> I have concrete details to share.
>>>
>>> Side note my build check completed successfully, although it took quite a
>>> bit of time: I cleaned my local maven repo to make sure that things
>>> really
>>> work from the clean state.
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html
>>> Sent from the Apache Ignite Developers mailing list archive at
>>> Nabble.com.
>
>
>
>
>
> --
> View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html <http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html>
> Sent from the Apache Ignite Developers mailing list archive at Nabble.com <http://nabble.com/>.

[oignatenko]

Denis,

As far as I can tell renames are now finalized in the way you proposed yesterday. I re-run my checks for build, module unit tests and examples (everything went fine) and updated draft doc for readme.io accordingly.

You can find most recent version of the draft doc attached to JIRA IGNITE-4964

regards, Oleg

Denis Magda wrote

Thanks Oleg, I’ll review the doc a bit later.

Yuri, I’ve reopened IGNITE-5000. Please consider my latest notes and prepare one more pull-request:
https://issues.apache.org/jira/browse/IGNITE-5000 <https://issues.apache.org/jira/browse/IGNITE-5000>

—
Denis

> On Apr 17, 2017, at 8:48 AM, oignatenko <[hidden email]> wrote:
>
> Denis, I prepared preliminary draft doc for readme.io <http://readme.io/>, it reflects proposed
> rename. You can find it attached to JIRA IGNITE-4964
>
> With regards to merge, per my reading of recent mail from Yury it is done
> except for module rename which is on its way to master now.
>
> regards, Oleg
>
>
> Denis Magda-2 wrote
>> Oleg, Nikita, Yuri,
>>
>> Frankly, I don’t like how the module is named presently which is
>> 'ignite-math’.
>>
>> I propose to rename it to ‘ignite-ml’. Presently, it holds a small
>> fraction of all ML functionality we might have in the future and this is
>> why, thinking of future, it will be a right decision to name it
>> accordingly.
>>
>> Any concerns?
>>
>> BTW, have the module been fully merged? I want to try to build it and
>> check the examples.
>>
>> —
>> Denis
>>
>>> On Apr 14, 2017, at 7:05 AM, oignatenko <
>
>> oignatenko@
>
>> > wrote:
>>>
>>> Thank you Denis, that sounds like a good plan. I am working on it now. I
>>> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it
>>> when
>>> I have concrete details to share.
>>>
>>> Side note my build check completed successfully, although it took quite a
>>> bit of time: I cleaned my local maven repo to make sure that things
>>> really
>>> work from the clean state.
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html
>>> Sent from the Apache Ignite Developers mailing list archive at
>>> Nabble.com.
>
>
>
>
>
> --
> View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html <http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html>
> Sent from the Apache Ignite Developers mailing list archive at Nabble.com <http://nabble.com/>.

[dmagda]

Oleg,

Perfect, thanks! Both Prachi and I reviewed your documentation and put it on the readme. IGNITE-4964 is closed.

Please, put some extra efforts as a part of Ignite 2.0 release considering latests review notes in this ticket:
https://issues.apache.org/jira/browse/IGNITE-5018 <https://issues.apache.org/jira/browse/IGNITE-5018>

—
Denis

> On Apr 18, 2017, at 10:20 AM, oignatenko <[hidden email]> wrote:
>
> Denis,
>
> As far as I can tell renames are now finalized in the way you proposed
> yesterday. I re-run my checks for build, module unit tests and examples
> (everything went fine) and updated draft doc for readme.io accordingly.
>
> You can find most recent version of the draft doc attached to JIRA
> IGNITE-4964
>
> regards, Oleg
>
>
> Denis Magda wrote
>> Thanks Oleg, I’ll review the doc a bit later.
>>
>> Yuri, I’ve reopened IGNITE-5000. Please consider my latest notes and
>> prepare one more pull-request:
>> https://issues.apache.org/jira/browse/IGNITE-5000
>> &lt;https://issues.apache.org/jira/browse/IGNITE-5000&gt;
>>
>> —
>> Denis
>>
>>> On Apr 17, 2017, at 8:48 AM, oignatenko &lt;
>
>> oignatenko@
>
>> &gt; wrote:
>>>
>>> Denis, I prepared preliminary draft doc for readme.io
>>> &lt;http://readme.io/&gt;, it reflects proposed
>>> rename. You can find it attached to JIRA IGNITE-4964
>>>
>>> With regards to merge, per my reading of recent mail from Yury it is done
>>> except for module rename which is on its way to master now.
>>>
>>> regards, Oleg
>>>
>>>
>>> Denis Magda-2 wrote
>>>> Oleg, Nikita, Yuri,
>>>>
>>>> Frankly, I don’t like how the module is named presently which is
>>>> 'ignite-math’.
>>>>
>>>> I propose to rename it to ‘ignite-ml’. Presently, it holds a small
>>>> fraction of all ML functionality we might have in the future and this is
>>>> why, thinking of future, it will be a right decision to name it
>>>> accordingly.
>>>>
>>>> Any concerns?
>>>>
>>>> BTW, have the module been fully merged? I want to try to build it and
>>>> check the examples.
>>>>
>>>> —
>>>> Denis
>>>>
>>>>> On Apr 14, 2017, at 7:05 AM, oignatenko &lt;
>>>
>>>> oignatenko@
>>>
>>>> &gt; wrote:
>>>>>
>>>>> Thank you Denis, that sounds like a good plan. I am working on it now.
>>>>> I
>>>>> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it
>>>>> when
>>>>> I have concrete details to share.
>>>>>
>>>>> Side note my build check completed successfully, although it took quite
>>>>> a
>>>>> bit of time: I cleaned my local maven repo to make sure that things
>>>>> really
>>>>> work from the clean state.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> View this message in context:
>>>>> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html
>>>>> Sent from the Apache Ignite Developers mailing list archive at
>>>>> Nabble.com.
>>>
>>>
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html
>>> &lt;http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html&gt;
>>> Sent from the Apache Ignite Developers mailing list archive at Nabble.com
>>> &lt;http://nabble.com/&gt;.
>
>
>
>
>
> --
> View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16878.html
> Sent from the Apache Ignite Developers mailing list archive at Nabble.com.