A stall in our review pipeline

[Ilya Kasnacheev]

Hello fellow developers!

It seems that we have problems with our review process currently, which
wasn't there before.

People seem to have stopped reviewing PRs for tickets where they have
competence, even these which they have filed themself or when they were
explicitly notified of a patch.

I have the following tickets in the pipeline currently, all in PA and with
green visa.

https://issues.apache.org/jira/browse/IGNITE-9215
https://github.com/apache/ignite/pull/8052
https://issues.apache.org/jira/browse/IGNITE-13384
https://github.com/apache/ignite/pull/8276
https://issues.apache.org/jira/browse/IGNITE-13431
https://github.com/apache/ignite/pull/8277

Please pay some attention even if you're not the original intended
reviewer. If it turns out that it does not work in lazy mode anymore, maybe
some explicit measures are needed.

Regards,
--
Ilya Kasnacheev

[dmagda]

I do acknowledge that the problem exists - a number of contributions and
pull-requests are piling up while we don't have any community-wide practice
to shorten the backlog. Let's use this conversation to see how we can turn
things  upside-down. I'll contemplate on my end.

Btw, Ilya, just curious, are contributors responding when you ping them
privately? That helped me on many occasions because many of us miss JIRA
notifications in our swamped email inboxes.

-
Denis


On Thu, Oct 1, 2020 at 3:06 AM Ilya Kasnacheev <[hidden email]>
wrote:

> Hello fellow developers!
>
> It seems that we have problems with our review process currently, which
> wasn't there before.
>
> People seem to have stopped reviewing PRs for tickets where they have
> competence, even these which they have filed themself or when they were
> explicitly notified of a patch.
>
> I have the following tickets in the pipeline currently, all in PA and with
> green visa.
>
> https://issues.apache.org/jira/browse/IGNITE-9215
> https://github.com/apache/ignite/pull/8052
> https://issues.apache.org/jira/browse/IGNITE-13384
> https://github.com/apache/ignite/pull/8276
> https://issues.apache.org/jira/browse/IGNITE-13431
> https://github.com/apache/ignite/pull/8277
>
> Please pay some attention even if you're not the original intended
> reviewer. If it turns out that it does not work in lazy mode anymore, maybe
> some explicit measures are needed.
>
> Regards,
> --
> Ilya Kasnacheev
>

[Ilya Kasnacheev]

Hello!

I didn't, since I consider writing directly to private email addresses too
intrusive. I would rather see my commits reviewed by folks who have time
rather than trying to persuade original ticket creator who does not have
time.

Regards,
--
Ilya Kasnacheev


чт, 1 окт. 2020 г. в 18:41, Denis Magda <[hidden email]>:

> I do acknowledge that the problem exists - a number of contributions and
> pull-requests are piling up while we don't have any community-wide practice
> to shorten the backlog. Let's use this conversation to see how we can turn
> things  upside-down. I'll contemplate on my end.
>
> Btw, Ilya, just curious, are contributors responding when you ping them
> privately? That helped me on many occasions because many of us miss JIRA
> notifications in our swamped email inboxes.
>
> -
> Denis
>
>
> On Thu, Oct 1, 2020 at 3:06 AM Ilya Kasnacheev <[hidden email]>
> wrote:
>
> > Hello fellow developers!
> >
> > It seems that we have problems with our review process currently, which
> > wasn't there before.
> >
> > People seem to have stopped reviewing PRs for tickets where they have
> > competence, even these which they have filed themself or when they were
> > explicitly notified of a patch.
> >
> > I have the following tickets in the pipeline currently, all in PA and
> with
> > green visa.
> >
> > https://issues.apache.org/jira/browse/IGNITE-9215
> > https://github.com/apache/ignite/pull/8052
> > https://issues.apache.org/jira/browse/IGNITE-13384
> > https://github.com/apache/ignite/pull/8276
> > https://issues.apache.org/jira/browse/IGNITE-13431
> > https://github.com/apache/ignite/pull/8277
> >
> > Please pay some attention even if you're not the original intended
> > reviewer. If it turns out that it does not work in lazy mode anymore,
> maybe
> > some explicit measures are needed.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
>

[Andrew Mashenkov]

Hi Ilya,

Thanks for the notice.
I've reviewed these PRs. They all look good, but I have few questions.
Please, take a look.

On Thu, Oct 1, 2020 at 1:06 PM Ilya Kasnacheev <[hidden email]>
wrote:

> Hello fellow developers!
>
> It seems that we have problems with our review process currently, which
> wasn't there before.
>
> People seem to have stopped reviewing PRs for tickets where they have
> competence, even these which they have filed themself or when they were
> explicitly notified of a patch.
>
> I have the following tickets in the pipeline currently, all in PA and with
> green visa.
>
> https://issues.apache.org/jira/browse/IGNITE-9215
> https://github.com/apache/ignite/pull/8052
> https://issues.apache.org/jira/browse/IGNITE-13384
> https://github.com/apache/ignite/pull/8276
> https://issues.apache.org/jira/browse/IGNITE-13431
> https://github.com/apache/ignite/pull/8277
>
> Please pay some attention even if you're not the original intended
> reviewer. If it turns out that it does not work in lazy mode anymore, maybe
> some explicit measures are needed.
>
> Regards,
> --
> Ilya Kasnacheev
>

--
Best regards,
Andrey V. Mashenkov

[Ilya Kasnacheev]

Hello!

Thank you for your effort, Andrey!

I have answered to your comment and took care of the rest.

Regards,
--
Ilya Kasnacheev


пт, 2 окт. 2020 г. в 14:21, Andrey Mashenkov <[hidden email]>:

> Hi Ilya,
>
> Thanks for the notice.
> I've reviewed these PRs. They all look good, but I have few questions.
> Please, take a look.
>
> On Thu, Oct 1, 2020 at 1:06 PM Ilya Kasnacheev <[hidden email]>
> wrote:
>
> > Hello fellow developers!
> >
> > It seems that we have problems with our review process currently, which
> > wasn't there before.
> >
> > People seem to have stopped reviewing PRs for tickets where they have
> > competence, even these which they have filed themself or when they were
> > explicitly notified of a patch.
> >
> > I have the following tickets in the pipeline currently, all in PA and
> with
> > green visa.
> >
> > https://issues.apache.org/jira/browse/IGNITE-9215
> > https://github.com/apache/ignite/pull/8052
> > https://issues.apache.org/jira/browse/IGNITE-13384
> > https://github.com/apache/ignite/pull/8276
> > https://issues.apache.org/jira/browse/IGNITE-13431
> > https://github.com/apache/ignite/pull/8277
> >
> > Please pay some attention even if you're not the original intended
> > reviewer. If it turns out that it does not work in lazy mode anymore,
> maybe
> > some explicit measures are needed.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
>
>
> --
> Best regards,
> Andrey V. Mashenkov
>