A few small pull requests

[sdarlington]

Hi,

I have a few small quality-of-life pull requests languishing in the backlog. Can anyone take a look or suggest what else I need to do to progress them?

IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <https://github.com/apache/ignite/pull/6877>
IGNITE-12182 ExecutorService defaults to only server nodes <https://github.com/apache/ignite/pull/6876>
IGNITE-11715 Allow extra options to be passed in to ignite.sh from Docker <https://github.com/apache/ignite/pull/6552>

Thanks,
Stephen

[dmagda]

Hi Stephen,

Thanks for reminding us about these pending contributions.

IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
> https://github.com/apache/ignite/pull/6877>


Merged the changes. Thanks!

IGNITE-12182 ExecutorService defaults to only server nodes <
> https://github.com/apache/ignite/pull/6876>


I'm afraid we can't merge this change until Ignite 3.0. Otherwise, it will
break backward compatibility.

IGNITE-11715 Allow extra options to be passed in to ignite.sh from Docker <
> https://github.com/apache/ignite/pull/6552>


Could you confirm that the JIRA ticket is correct? Whenever I try to open
IGNITE-11715 in JIRA it redirects me to
https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-13264


-
Denis


On Wed, Jul 15, 2020 at 6:42 AM Stephen Darlington <
[hidden email]> wrote:

> Hi,
>
> I have a few small quality-of-life pull requests languishing in the
> backlog. Can anyone take a look or suggest what else I need to do to
> progress them?
>
> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
> https://github.com/apache/ignite/pull/6877>
> IGNITE-12182 ExecutorService defaults to only server nodes <
> https://github.com/apache/ignite/pull/6876>
> IGNITE-11715 Allow extra options to be passed in to ignite.sh from Docker <
> https://github.com/apache/ignite/pull/6552>
>
> Thanks,
> Stephen
>
>

[sdarlington]

This link works for me: https://issues.apache.org/jira/browse/IGNITE-11715 <https://issues.apache.org/jira/browse/IGNITE-11715>

> On 16 Jul 2020, at 16:47, Denis Magda <[hidden email]> wrote:
>
> Hi Stephen,
>
> Thanks for reminding us about these pending contributions.
>
> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
>> https://github.com/apache/ignite/pull/6877>
>
>
> Merged the changes. Thanks!
>
> IGNITE-12182 ExecutorService defaults to only server nodes <
>> https://github.com/apache/ignite/pull/6876>
>
>
> I'm afraid we can't merge this change until Ignite 3.0. Otherwise, it will
> break backward compatibility.
>
> IGNITE-11715 Allow extra options to be passed in to ignite.sh from Docker <
>> https://github.com/apache/ignite/pull/6552>
>
>
> Could you confirm that the JIRA ticket is correct? Whenever I try to open
> IGNITE-11715 in JIRA it redirects me to
> https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-13264
>
>
> -
> Denis
>
>
> On Wed, Jul 15, 2020 at 6:42 AM Stephen Darlington <
> [hidden email]> wrote:
>
>> Hi,
>>
>> I have a few small quality-of-life pull requests languishing in the
>> backlog. Can anyone take a look or suggest what else I need to do to
>> progress them?
>>
>> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
>> https://github.com/apache/ignite/pull/6877>
>> IGNITE-12182 ExecutorService defaults to only server nodes <
>> https://github.com/apache/ignite/pull/6876>
>> IGNITE-11715 Allow extra options to be passed in to ignite.sh from Docker <
>> https://github.com/apache/ignite/pull/6552>
>>
>> Thanks,
>> Stephen
>>
>>

[dmagda]

Weird, works now. Seems to be some browser-related issue on my end.

Overall, thanks a lot for the contribution. I'm suggesting us to merge
IGNITE-11715 into the Ignite 2.9 release branch. Left details in JIRA.

-
Denis


On Thu, Jul 16, 2020 at 9:44 AM Stephen Darlington <
[hidden email]> wrote:

> This link works for me: https://issues.apache.org/jira/browse/IGNITE-11715
> <https://issues.apache.org/jira/browse/IGNITE-11715>
>
> > On 16 Jul 2020, at 16:47, Denis Magda <[hidden email]> wrote:
> >
> > Hi Stephen,
> >
> > Thanks for reminding us about these pending contributions.
> >
> > IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
> >> https://github.com/apache/ignite/pull/6877>
> >
> >
> > Merged the changes. Thanks!
> >
> > IGNITE-12182 ExecutorService defaults to only server nodes <
> >> https://github.com/apache/ignite/pull/6876>
> >
> >
> > I'm afraid we can't merge this change until Ignite 3.0. Otherwise, it
> will
> > break backward compatibility.
> >
> > IGNITE-11715 Allow extra options to be passed in to ignite.sh from
> Docker <
> >> https://github.com/apache/ignite/pull/6552>
> >
> >
> > Could you confirm that the JIRA ticket is correct? Whenever I try to open
> > IGNITE-11715 in JIRA it redirects me to
> > https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-13264
> >
> >
> > -
> > Denis
> >
> >
> > On Wed, Jul 15, 2020 at 6:42 AM Stephen Darlington <
> > [hidden email]> wrote:
> >
> >> Hi,
> >>
> >> I have a few small quality-of-life pull requests languishing in the
> >> backlog. Can anyone take a look or suggest what else I need to do to
> >> progress them?
> >>
> >> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
> >> https://github.com/apache/ignite/pull/6877>
> >> IGNITE-12182 ExecutorService defaults to only server nodes <
> >> https://github.com/apache/ignite/pull/6876>
> >> IGNITE-11715 Allow extra options to be passed in to ignite.sh from
> Docker <
> >> https://github.com/apache/ignite/pull/6552>
> >>
> >> Thanks,
> >> Stephen
> >>
> >>
>
>
>

[sdarlington]

I had the same problem with “your" link… not sure what is going on!

I’ve added suggestions for documentation in the ticket as suggested.

Regards,
Stephen

> On 17 Jul 2020, at 01:00, Denis Magda <[hidden email]> wrote:
>
> Weird, works now. Seems to be some browser-related issue on my end.
>
> Overall, thanks a lot for the contribution. I'm suggesting us to merge
> IGNITE-11715 into the Ignite 2.9 release branch. Left details in JIRA.
>
> -
> Denis
>
>
> On Thu, Jul 16, 2020 at 9:44 AM Stephen Darlington <
> [hidden email]> wrote:
>
>> This link works for me: https://issues.apache.org/jira/browse/IGNITE-11715
>> <https://issues.apache.org/jira/browse/IGNITE-11715>
>>
>>> On 16 Jul 2020, at 16:47, Denis Magda <[hidden email]> wrote:
>>>
>>> Hi Stephen,
>>>
>>> Thanks for reminding us about these pending contributions.
>>>
>>> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
>>>> https://github.com/apache/ignite/pull/6877>
>>>
>>>
>>> Merged the changes. Thanks!
>>>
>>> IGNITE-12182 ExecutorService defaults to only server nodes <
>>>> https://github.com/apache/ignite/pull/6876>
>>>
>>>
>>> I'm afraid we can't merge this change until Ignite 3.0. Otherwise, it
>> will
>>> break backward compatibility.
>>>
>>> IGNITE-11715 Allow extra options to be passed in to ignite.sh from
>> Docker <
>>>> https://github.com/apache/ignite/pull/6552>
>>>
>>>
>>> Could you confirm that the JIRA ticket is correct? Whenever I try to open
>>> IGNITE-11715 in JIRA it redirects me to
>>> https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-13264
>>>
>>>
>>> -
>>> Denis
>>>
>>>
>>> On Wed, Jul 15, 2020 at 6:42 AM Stephen Darlington <
>>> [hidden email]> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have a few small quality-of-life pull requests languishing in the
>>>> backlog. Can anyone take a look or suggest what else I need to do to
>>>> progress them?
>>>>
>>>> IGNITE-12192 Allow ignitevisorcmd to quit when pressing ^D <
>>>> https://github.com/apache/ignite/pull/6877>
>>>> IGNITE-12182 ExecutorService defaults to only server nodes <
>>>> https://github.com/apache/ignite/pull/6876>
>>>> IGNITE-11715 Allow extra options to be passed in to ignite.sh from
>> Docker <
>>>> https://github.com/apache/ignite/pull/6552>
>>>>
>>>> Thanks,
>>>> Stephen
>>>>
>>>>
>>
>>
>>